Codereview unused variabelen en zo

svn path=/Website/trunk/; revision=54496

APPL/CHAT/notify.js

@@ -68,7 +68,7 @@ var notify =
             notify.callback(data);
         else if (data && ("last_alive" in data || "end" in data))
         {
-            if (notify.callback(data) != false)
+            if (notify.callback(data))
                 notify.timeoutTimer = setTimeout(notify.check, CHECKTIME);
         }
         else

APPL/Consoles/alg_locatie.js

@@ -884,7 +884,7 @@ $(function() {
                 $("#" + targets.list_issues.selector).closest(".row").attr("hidden", false);
                 var disciplinetypes = {},
                     disciplines = {},
-                    index, key_count;
+                    key_count;
                 // save id's of issuetypes used in table and return the occurences per issuetype
                 key_count = saveUsedtabledataIds({
                     name: "issuetype",
@@ -1129,8 +1129,7 @@ $(function() {
     // function to filter data on DataTables
     $.fn.dataTable.ext.search.push(
         function(settings, data, dataIndex) {
-            var target = $("#" + settings.sTableId).attr("name"),
-                index;
+            var target = $("#" + settings.sTableId).attr("name");
             // filter list_issues rows on selected disciplinetype buttons, non selected = show all rows
             if (target == "list_issues") {
                 if (!!targets.list_issues.data_table && !!targets.filter_issuetypes.selected_ids && ($("button." + window.settings.btn_selected_class, "#filter-disciplinetypes").length > 0)) {

APPL/Consoles/console.js

@@ -176,7 +176,7 @@ function typeFormat(parms) {
                 hour: '2-digit',
                 minute: '2-digit'
             }).format(new Date(parms.value));
-            break;
+            // niet na een return break;
         case "date":
             if (parms.single) {
                 // return the datevalue in case of a single object column
@@ -185,14 +185,14 @@ function typeFormat(parms) {
             return new Intl.DateTimeFormat(undefined, {
                 dateStyle: 'medium'
             }).format(new Date(parms.value));
-            break;
+            // niet na een return break;
         case "integer":
             return parseInt(parms.value, 10);
-            break;
+            // niet na een return break;
         case "number":
             // return safe number
             return $.fn.dataTable.render.number().display(parms.value);
-            break;
+            // niet na een return break;
         default:
             // return safe text
             return $.fn.dataTable.render.text().display(parms.value);
@@ -275,7 +275,7 @@ function dataOrder(obj, row, column) {
         case "datetime":
         case "date":
             return new Date(value).getTime();
-            break;
+            // niet na een return break;
         default:
             return false;
     }
@@ -346,7 +346,7 @@ function formData(obj) {
     "use strict";
     var target_selector = targets[obj.target].selector;
     var formbody = "",
-        column, column_id, col_info, field, type, date, time;
+        column, column_id, col_info;
     for (column in obj.columns) {
         if (column !== "id" && !(targets[obj.target].columns[column].hidden || false)) {
             column_id = target_selector + "-" + column;
@@ -368,7 +368,7 @@ function filterData(obj) {
     "use strict";
     //    var container_selector = targets[obj.target].selector;
     var formbody = "",
-        row, column, column_id, col_info, field,
+        row, column, col_info,
         btn_size_class = targets[obj.target].btn_size_class,
         btn_has_icon = targets[obj.target].btn_has_icon,
         icon_column = targets[obj.target].icon_column,
@@ -743,23 +743,23 @@ function Field(parms) {
                 return '<div class="col-sm-8 progress" style="height: 2rem;">' +
                     '<div class="progress-bar progress-bar-info form-control form-control-sm" role="progressbar" id="' + self.column_id + '" style="width: ' + Math.round(1 / self.column_valuemax * self.column_data * 100) + '%;" aria-valuenow="' + self.column_data + '" aria-valuemin="' + self.column_valuemin + '" aria-valuemax="' + self.column_valuemax + '"></div>' +
                     '</div>';
-                break;
+                // niet na een return break;
             case "check":
                 return '<div class="form-check">' +
                     '<input type="checkbox" class="form-control form-control-sm form-check-input" id="' + self.column_id + '" name=' + self.column_name + (self.column_data == 1 ? ' checked' : '') + ' disabled>' +
                     '</div>';
-                break;
+                // niet na een return break;
             case "textarea":
                 return '<div class="col-sm-8">' +
                     '<textarea class="sm-textarea form-control form-control-sm" id="' + self.column_id + '" readonly>' + self.column_data + '</textarea>' +
                     '</div>';
-                break;
+                // niet na een return break;
             case "date":
                 date = self.column_data == "" ? "" : self.column_data.getFullYear().toString() + "-" + prefixZero((self.column_data.getMonth() + 1).toString(), 2) + "-" + prefixZero(self.column_data.getDate().toString(), 2);
                 return '<div class="col-sm-8">' +
                     '<input type="date" class="form-control form-control-sm" id="' + self.column_id + '" name=' + self.column_name + '" value="' + date + '" readonly>' +
                     '</div>';
-                break;
+                // niet na een return break;
             case "datetime":
                 time = self.column_data == "" ? "" : prefixZero(self.column_data.getHours().toString(), 2) + ":" + prefixZero(self.column_data.getMinutes().toString(), 2);
                 date = self.column_data == "" ? "" : self.column_data.getFullYear().toString() + "-" + prefixZero((self.column_data.getMonth() + 1).toString(), 2) + "-" + prefixZero(self.column_data.getDate().toString(), 2);
@@ -769,18 +769,18 @@ function Field(parms) {
                     '<div class="col-sm-3">' +
                     '<input type="time" class="form-control form-control-sm" id="' + self.column_id + '_time" name=' + self.column_name + '_time" value="' + time + '" readonly>' +
                     '</div>';
-                break;
+                // niet na een return break;
             case "time":
                 time = self.column_data == "" ? "" : prefixZero(self.column_data.getHours().toString(), 2) + ":" + prefixZero(self.column_data.getMinutes().toString(), 2);
                 return '<div class="col-sm-3">' +
                     '<input type="time" class="form-control form-control-sm" id="' + self.column_id + '_time" name=' + self.column_name + '_time" value="' + time + '" readonly>' +
                     '</div>';
-                break;
+                // niet na een return break;
             default:
                 return '<div class="col-sm-8">' +
                     '<input type="' + self.column_type + '" class="form-control form-control-sm" id="' + self.column_id + '" name=' + self.column_name + '" value="' + self.column_data + '" readonly>' +
                     '</div>';
-                break
+                // niet na een return break;
         }
     }
     console.log(self);
@@ -828,8 +828,7 @@ function Customfield(parms) {
 // Object with render function to return html for all customfields including labels
 function Customfields(parms) {
     "use strict";
-    var self = this,
-        custom_field;
+    var self = this;
     // sort customfields on sequence
     this.custom_fields = (parms.data[parms.table].custom_fields ? parms.data[parms.table].custom_fields.sort(function (a, b) {
         return (a.sequence > b.sequence ? 1 : -1)

APPL/Localscripts/plaatsselector.js

@@ -493,7 +493,7 @@ var plaatsselector =
                 {
                   callback: function (data)
                             {
-                               var a = 1;
+                               // var a = 1;
                             }
                 });
     }

APPL/RES/res_plan.js

@@ -350,7 +350,7 @@ function res_deel_grid_click(rdeel)
     }
     var disc = $this.parent().attr("data-disc");
     var row = $this.parent().attr("data-row");
-    $("div.gepland.res_nieuw[data-disc=" + disc + "][data-row=" + row + "]").toggleClass("selected", $this.prop("checked")).toggleClass("unselected", $this.prop("checked") == false);
+    $("div.gepland.res_nieuw[data-disc=" + disc + "][data-row=" + row + "]").toggleClass("selected", $this.prop("checked")).toggleClass("unselected", !$this.prop("checked"));
 }
 
 function showTotPriceArt(number)

APPL/SlnkDwf/ToonIMG.js

@@ -981,7 +981,7 @@ function _onKeyDown(evt)
                  // door de _invalidateMap() hebben we geen SystemMap meer
                  _refresh(false); // Luie manier om alles te herstellen
                  return;
-                 break;
+                 // geen break na een return break;
         case 38:dy=-1;break;
         case 40:dy=1;break;
         case 37:dx=-1;break;