QA-check enkele false positive warnings wegwerken

svn path=/Website/trunk/; revision=55877

APPL/CAD/EvictionPlan.asp

@@ -50,7 +50,6 @@ function myRefresh(numFlr, dwfName)
 {
     MMap.Reset();
     MMap.SetIMGGenerator("../CAD/mySlnk2IMGEv.asp");
-    //MMap.SetPaperColor(<%=S("fg_paperColor")%>);  // niet de graphics-kleur
     MMap.SetCustomParameters("&vKey=" + numFlr + "&dwfName=" + escape(dwfName));
     MMap.Refresh(true); // Do zoom extents
 }
@@ -170,4 +169,4 @@ function onOtherDrawing()
 </body>
 
 </html>
-<% ASPPAGE_END(); %> 
+<% ASPPAGE_END(); %>

APPL/FAC/fac_header.inc

@@ -345,11 +345,8 @@ function generateHeaderFunctions (params)
             src = window.location.href;
 
         var url = 'appl/fac/help.asp?url='+escape(src);
-// ALTIJD in een nieuw window.
-//        if (<%=S("help_window")?"false":"true"%>)
-//            FcltMgr.openDetail(url,'<%=L("lcl_help")%>');
-//        else
-            FcltMgr.windowopen('../../'+url);
+        // Altijd in new window om cross-domain problemen te voorkomen
+        FcltMgr.windowopen('../../'+url);
     }
 
     function myInfo()
@@ -435,7 +432,7 @@ function generateHeaderFunctions (params)
         page = "../prs/prs_move_perslidwerkplek.asp?pwp_key=" + key;
         FcltMgr.openModalDetail(page);
       }
-      
+
     }
 
     $(function()

APPL/Localscripts/notes.js

@@ -169,13 +169,13 @@ function init_detailToggle(pnote_key)
                              "tracking": ".note-type-tracking",
                              "fehidden": ".note-fe-hidden" };
 
-    var hasNotes            = $(toggle_selectors["notes"]).length ? 1 : 0;
+//    var hasNotes            = $(toggle_selectors["notes"]).length ? 1 : 0;
     var hasTracking         = $(toggle_selectors["tracking"]).length ? 1 : 0;
     var hasMoreToggle       = $(".note-toggler").length ? 1 : 0;
     var hasHiddenNotes      = $(toggle_selectors["fehidden"]).length ? 1 : 0;
     var nf_arr              = (window.localStorage.getItem("notitiefilter") || "").split(",");
 
-    if (true) // Anders valt er niets te togglen, *edit; altijd relevante toggles tonen zodat je bijv. default tracking altijd kan onderdrukken
+//    if (true) // Anders valt er niets te togglen, *edit; altijd relevante toggles tonen zodat je bijv. default tracking altijd kan onderdrukken
     {
         //if (false && hasMultipleToggles && hasNotes) // Vooralsnog uitgeschakeld
         //    $(".btn-group").append("<button id='notes-toggle-button' class='button selected' title='" + L("lcl_mld_frame_notes") + "'>" + I("fa-comment-alt-lines") + "</button>");

APPL/PDA/mobile.js

@@ -234,7 +234,7 @@ function onBijlagenMobile(formurl, // protected
                 else
                     $(objButton).parent().nextAll("img.kenmerk").hide();
 
-                if ($(objButton).data("fclt-app") == true)
+                if ($(objButton).data("fclt-app") == 'true')
                     location.href = "swipe:enable";
 
                 if (window.return_data.fileName) {

UTILS/Exchange/ms_graph.js

@@ -39,6 +39,11 @@ function requestTokenForUser(config)
         var oRs = Oracle.Execute(sql);
         var glob = new ActiveXObject("Chilkat_9_5_0.Global");
         var success = glob.UnlockBundle(oRs("fac_setting_value").Value);
+        if (success != 1)
+        {
+            __Log("Chilkat_9_5_0 Unlock failed:\n" + oChilglob.LastErrorText);
+            return null;
+        }
         oRs.Close();
         token = requestTokenWithCertificate(config);
     }